Re: [PATCH 3/3] clone: always fetch remote HEAD
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Jun 4, 2011, 01:50 UTC
- Message-ID
- <BANLkTimuU6fxS+CoL=rpQbN4vfRyMNOMJQ@mail.gmail.com>
- In-Reply-To
- <20110603181052.GA17538@sigill.intra.peff.net>
Heya,
On Fri, Jun 3, 2011 at 13:10, Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
> Or is it the fault of testgit for calling exporter.export_repo twice? It > seems to ignore the ref argument it gets to import, and just dumps the > whole repo, albeit into an alternate namespace. Should we then be doing > something per-ref with the result? Or since our particular import > imports everything, should we simply ignore further imports after the > first one?
I never tested testgit with multiple import arguments, as I wasn't sure how it was supposed to work in the first place.
> Does that make sense? If so, then I think the right fix is for testgit > ti ignore all imports after the first one (since the first one will have > done all available refs). And the patch is:
We can do that yes, although it would be even better if we could make testgit implement importing only a limited set of branches, as I assume that will be common. Nonetheless, this will do for now I think.
-- Cheers, Sverre Rabbelier