Re: [PATCH 3/3] clone: always fetch remote HEAD
- From
Jeff King <peff@peff.net>
- Date
- Jun 3, 2011, 05:43 UTC
- Message-ID
- <20110603054303.GA5341@sigill.intra.peff.net>
- In-Reply-To
- <BANLkTim03_3DLdDkc3QgFrcUa0Fqhhqnbw@mail.gmail.com>
On Fri, Jun 03, 2011 at 12:36:50AM -0500, Sverre Rabbelier wrote:
Show 11 quoted lines
> On Fri, Jun 3, 2011 at 00:18, Jeff King <peff@peff.net> wrote: > > So I guess it doesn't like us asking for HEAD. But the fact that it > > sends weird data to fast-import instead of saying "hey, HEAD doesn't > > exist" has me confused. I'm not sure if this is something one should not > > be doing with remote helpers, or if the testgit helper is simply buggy > > or incomplete. > > Definitely the latter, quite possibly the former. I don't know if > asking for "HEAD" makes much sense in a remote-helper context though. > In Mercurial it does (e.g., tip), and in svn sort of, but I don't know > about other vcs-es. Perhaps it should be guarded by a capability?
Yeah, I think it depends on the helper. Definitely smart-http should be able to do it. But protecting it with a capability does make sense, and then remote helpers can opt into it.
-Peff