Re: [PATCH v4 (for maint)] git-completion: fix zsh support

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 9, 2011, 23:13 UTC
Message-ID: <BANLkTim1Di2ABtrv8ncVPT6+vCvq5pD_kw@mail.gmail.com>
In-Reply-To: <20110509225307.GG22908@elie>

On Tue, May 10, 2011 at 1:53 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 5 quoted lines

> Felipe Contreras wrote:
>
>> v4: more commit message improvements
>
> Thanks.  You seem to have ignored most of my review;

I did not ignore it, I replied to your comments. A review doesn't meant that I should do what you say.

Show 7 quoted lines

> I'll try to find
> time to clarify the commit message if the consensus is that this
> approach is a good idea.
>
> An alternative possibility if we need this fixed in the v1.7.5.x
> series (do we?) would be cherry-picking the fix from
> sg/completion-updates on top of maint.

Which cannot be done; you need the rest of the cleanups. Otherwise you would have to make many many intrusive changes.

Show 5 quoted lines

> To clarify the trade-offs:
>
>  - in terms of lines of code, the fix itself in sg/completion-updates
>   and this fix are about the same size.  But the sg/completion-updates
>   version relies on a code cleanup.

It's not:

fc: 1 files changed, 2 insertions(+), 0 deletions(-) sg: 1 files changed, 8 insertions(+), 0 deletions(-)

That is if I remove the comments I added; Gabor's version doesn't have any.

>  - the fix in sg/completion-updates is less likely to be broken by
>   future changes in the bashcompinit library.

How exactly?

>  - this fix is conceptually simpler.  In a way, the fix in
>   sg/completion-updates only works by accident.

You are missing other advantages:

- thix fix is less intrusive
- this fix would be easier to remove in the future (kind of comes from
the previous one)
- this fix has been acknowledge by zsh developers
- this fix can be applies both on 'maint' and on top of Gabor's
reorganization without changes

I really don't understand how adding two lines of code that make something from totally broken to working properly can be so difficult.

-- 
Felipe Contreras