git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 (for maint)] git-completion: fix zsh support

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 9, 2011, 23:58 UTC
Message-ID
<BANLkTikUe_Kwdi+F3vK-7kC9WNU-x_8LDw@mail.gmail.com>
In-Reply-To
<20110509232804.GB23781@elie>
On Tue, May 10, 2011 at 2:28 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 12 quoted lines
> Felipe Contreras wrote:
>> On Tue, May 10, 2011 at 1:53 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
>>>  - the fix in sg/completion-updates is less likely to be broken by
>>>   future changes in the bashcompinit library.
>>
>> How exactly?
>
> Because there remains the possibility that functions from bashcompinit
> will make use of the $words variable.  I have said this about three
> times.  It is not very likely, assuming the zsh developers want to keep
> supporting that fix (and I think they should), but the chance is there.

And I even wrote a test to show you that's not the case: http://article.gmane.org/gmane.comp.version-control.git/172963

Now, can you modify my test to explain how *exactly* zsh folks can screw my patch up?

Show 13 quoted lines
>>>  - this fix is conceptually simpler.  In a way, the fix in
>>>   sg/completion-updates only works by accident.
>>
>> You are missing other advantages:
>
> Sorry, I should have prefaced the above with "in my opinion".  And to
> be clear, I am not saying this fix should not be applied; I am just
> explaining the trade-offs as I understand them.
>
> The reason I asked for another opinion is that I find it hard to be
> objective in this case, because of another consideration I didn't
> mention: each moment I have been spending on this is an exercise in
> frustration.

Well, don't :) Just ask yourself this question: is the patch good enough? If not, send your own version.

Personally I think the latest version of the patch clearly explains what it is doing, and why. It even has comments on the code, which the other alternative doesn't.

-- 
Felipe Contreras
Previous: Jonathan NiederNext: Junio C Hamano
Message 8 of 19 in “git-completion: fix zsh support”
  1. git-completion: fix zsh supportFelipe Contreras, May 9, 2011
  2. Jonathan NiederMay 9, 2011
  3. Felipe ContrerasMay 9, 2011
  4. git-completion: fix zsh supportFelipe Contreras, May 9, 2011
  5. Jonathan NiederMay 9, 2011
  6. Felipe ContrerasMay 9, 2011
  7. Jonathan NiederMay 9, 2011
  8. Felipe ContrerasMay 9, 2011
  9. Junio C HamanoMay 9, 2011
  10. Jonathan NiederMay 9, 2011
  11. 0/2 git-completion: fix zsh supportJonathan Nieder, May 10, 2011
  12. 1/2 completion: suppress zsh's special 'words' variableJonathan Nieder, May 10, 2011
  13. Jonathan NiederMay 10, 2011
  14. Felipe ContrerasMay 10, 2011
  15. Felipe ContrerasMay 10, 2011
  16. 2/2 completion: move private shopt shim for zsh to __git_ namespaceJonathan Nieder, May 10, 2011
  17. Felipe ContrerasMay 10, 2011
  18. Jonathan NiederMay 10, 2011
  19. Felipe ContrerasMay 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.