Re: [PATCH] sh-18n: quell "unused variable" warning

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 26, 2011, 13:46 UTC
Message-ID: <BANLkTikmNxkCyAK1C4AWYVE-mjGYxKSLmQ@mail.gmail.com>
In-Reply-To: <4DDE4F92.7030301@drmicha.warpmail.net>

On Thu, May 26, 2011 at 15:03, Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 19 quoted lines

> Ævar Arnfjörð Bjarmason venit, vidit, dixit 26.05.2011 01:33:
>> On Wed, May 25, 2011 at 11:55, Michael J Gruber
>> <git@drmicha.warpmail.net> wrote:
>>
>> I suppose it was inevitable that we'd end up maintaining this since
>> upstream only maintains the GPLv3 version now.
>>
>>>   /* Default values for command line options.  */
>>> -  unsigned short int show_variables = 0;
>>> +  /* unsigned short int show_variables = 0; */
>>
>>> -         show_variables = 1;
>>> +         /* show_variables = 1; */
>>
>> Can we just remove these lines instead of commenting them out?
>
> Sure, I just didn't know what is more convenient for the maintainer. I
> noticed a few comments in there already but have not compared with
> upstream. Resend necessary?

No it's fine.

But I/we are the upstream for this program now, since GNU only maintains the GPLv3 version.

We could just use that actually, since this is a stand-alone program. Or do we have intrinsic objections to GPLv3 code in our source tree?