Re: [PATCH] sh-18n: quell "unused variable" warning

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: May 26, 2011, 13:03 UTC
Message-ID: <4DDE4F92.7030301@drmicha.warpmail.net>
In-Reply-To: <BANLkTi=Mgd7=eriOsz1phDBJ25Com2Y=mQ@mail.gmail.com>

Ævar Arnfjörð Bjarmason venit, vidit, dixit 26.05.2011 01:33:

Show 14 quoted lines

> On Wed, May 25, 2011 at 11:55, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
> 
> I suppose it was inevitable that we'd end up maintaining this since
> upstream only maintains the GPLv3 version now.
> 
>>   /* Default values for command line options.  */
>> -  unsigned short int show_variables = 0;
>> +  /* unsigned short int show_variables = 0; */
> 
>> -         show_variables = 1;
>> +         /* show_variables = 1; */
> 
> Can we just remove these lines instead of commenting them out?

Sure, I just didn't know what is more convenient for the maintainer. I noticed a few comments in there already but have not compared with upstream. Resend necessary?

Michael