Re: [PATCH 6/6] zlib: zlib can only process 4GB at a time
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Jun 12, 2011, 20:43 UTC
- Message-ID
- <BANLkTikmLDZj2qdkmF-kBUkB33o9EjtBpg@mail.gmail.com>
- In-Reply-To
- <1307736948-16956-7-git-send-email-gitster@pobox.com>
On Fri, Jun 10, 2011 at 10:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
> The size of objects we read from the repository and data we try to put > into the repository are represented in "unsigned long", so that on larger > architectures we can handle objects that weigh more than 4GB.
shouldn't this be "size_t" instead of "unsigned long"? "unsigned long" is 32bit on Win64, whereas size_t is 64bit:
http://msdn.microsoft.com/en-us/library/s3f49ktz(v=vs.80).aspx http://msdn.microsoft.com/en-us/library/aa384083(VS.85).aspx