git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/6] zlib: wrap deflate side of the API

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 10, 2011, 23:00 UTC
Message-ID
<7vvcwduwaf.fsf@alter.siamese.dyndns.org>
In-Reply-To
<BANLkTinz9VAL_j9hZeF=kuAPwU1+0yEyRw@mail.gmail.com>
Thiago Farina <tfransosi@gmail.com> writes:
Show 9 quoted lines
> On Fri, Jun 10, 2011 at 5:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> +void git_deflate_init_gzip(z_streamp strm, int level)
>> +{
>> +       /*
>> +        * Use default 15 bits, +16 is to generate gzip header/trailer
>> +        * instead of the zlib wrapper.
>> +        */
>> +       const int windowBits = 15 + 16;
> Was this style intentional?
Sorry, but what style specifically do you find questionable?
Previous: Thiago FarinaNext: Junio C Hamano
Message 7 of 16 in “zlib only processes 4GB at a time”
  1. 0/6 zlib only processes 4GB at a timeJunio C Hamano, Jun 10, 2011
  2. 1/6 zlib: refactor error message formatterJunio C Hamano, Jun 10, 2011
  3. 2/6 zlib: wrap remaining calls to direct inflate/inflateEndJunio C Hamano, Jun 10, 2011
  4. 3/6 zlib: wrap inflateInit2 used to accept only for gzip formatJunio C Hamano, Jun 10, 2011
  5. 4/6 zlib: wrap deflate side of the APIJunio C Hamano, Jun 10, 2011
  6. Thiago FarinaJun 10, 2011
  7. Junio C HamanoJun 10, 2011
  8. 5/6 zlib: wrap deflateBound() tooJunio C Hamano, Jun 10, 2011
  9. 6/6 zlib: zlib can only process 4GB at a timeJunio C Hamano, Jun 10, 2011
  10. Erik Faye-LundJun 12, 2011
  11. Junio C HamanoJun 12, 2011
  12. Matthieu MoyJun 12, 2011
  13. Erik Faye-LundJun 13, 2011
  14. Jonathan NiederJun 13, 2011
  15. Junio C HamanoJun 13, 2011
  16. 7/6 zlib: allow feeding more than 4GB in one goJunio C Hamano, Jun 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.