Re: [PATCH] git-cvsserver runs hooks/post-receive

From: Michael Witten <mfwitten@mit.edu>
Date: Dec 1, 2007, 00:19 UTC
Message-ID: <AB064BA5-1F99-4CCF-9BA5-048BB14E9157@MIT.EDU>
In-Reply-To: <47500F0B.10300@viscovery.net>

On 30 Nov 2007, at 8:24:27 AM, Johannes Sixt wrote:

Show 12 quoted lines

>> The difference is that it puts objects in place
>> by hand, requiring the code to mirror hook calls
>> anyway.
>> I'm simply proposing that the code be reworked,
>> so that cvs commits actually become git pushes,
>> so that all future changes to the pushing mechanism
>> are automatically handled.
>
> But in order push something, you must first have the commit in a  
> repository. How would git-cvsserver do that? For example, by  
> putting objects in place by hand. You gain nothing, except that it  
> would push instead of call the hooks directly.

"The difference is that it puts objects in place by hand, requiring the code to mirror hook calls anyway."

As far as I can tell, hook calls are the only thing.

However, I still had to write a patch to include post-receive; by doing everything by hand, git-cvsserver is inherently unsafe and incomplete over time.

The question is not the RESULT, but HOW YOU GET that result; the current design is---essentially---a hack; it is written in perl, after all ;-P