Re: [PATCH] git-cvsserver runs hooks/post-receive

From: Michael Witten <mfwitten@mit.edu>
Date: Nov 30, 2007, 04:06 UTC
Message-ID: <7F81126E-5A76-40CA-94BF-82B46C57AFF6@mit.edu>
In-Reply-To: <7v3aup291c.fsf@gitster.siamese.dyndns.org>

On 28 Nov 2007, at 7:24:31 PM, Junio C Hamano wrote:

Show 14 quoted lines

> Michael Witten <mfwitten@mit.edu> writes:
>
>> git-cvsserver just did the following:
>>     (1) run hooks/update
>>     (2) commit if hooks/update passed
>>
>> This commit simply adds:
>>     (3) run hooks/post-receive
>>
>> Also, there are a few grammar cleanups and
>> consistency improvements.
>
> I gave only a very cursory look; looks Ok to me.  This makes me wonder
> if post-update wants to run as well.

Seems like post-receive is supposed to supersede post-update anyhow, so might as well leave post-update out at this point?

In any case, I haven't taken a thorough look at how git-cvsserver works, but it seems to duplicate a lot of git-receive-pack.

How about turning git-cvsserver into a true middleman, so that it constructs a 'temporary git working tree' and then does a real git-push into the final git repository.

Because git-cvsserver would be using git-send-pack to do the pushing, it could push to yet another server. How cool is that!