Re: [PATCH] completion: Add PS1 configuration for submodules

From: Scott Kyle <scott@appden.com>
Date: Dec 7, 2010, 20:37 UTC
Message-ID: <AANLkTinuD2ze_mn5QMLqFaoftwZvTsz-DKv1ojAizg7P@mail.gmail.com>
In-Reply-To: <AANLkTin8JstkjEWaCGZuqpEXZnLMyudFm24K7Y3iCgX6@mail.gmail.com>

[sorry for the duplicate email, my original was rejected from the list]

On Tue, Dec 7, 2010 at 4:15 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 12 quoted lines

>
> On Tue, Dec 7, 2010 at 00:22, Scott Kyle <scott@appden.com> wrote:
> > For those who often work on repositories with submodules, the dirty
> > indicator for unstaged changes will almost always show because development
> > is simultaneously happening on those submodules. The config option
> > diff.ignoreSubmodules is not appropriate for this use because it has larger
> > implications.
>
> Wouldn't it be a lot better to instead add support for showing
> submodule dirtyness as distinct from the main tree's dirtyness? Then
> you could easily spot if you had either your tree / submodule tree
> changes, without just ignoring them.

I considered that, but thought it to be a rather disruptive change, and one that conceptually didn't work. The way I see it, either somebody thinks of their repo as dirty when the submodules are dirty, or not. And I think since this behavior has perpetuated for so long, most users are content with how it currently works. I, however, was not, and so that is why I added an option for people like me.

Scott Kyle

http://appden.com http://github.com/appden http://twitter.com/appden