Re: [TopGit PATCH 01/10] cat_file: take -i/-w parameters

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Oct 9, 2010, 20:57 UTC
Message-ID: <AANLkTinfMQ0OpqEfY7gVRU_CofxkV+SXiruMndKq+s3-@mail.gmail.com>
In-Reply-To: <20101009203219.GN29673@pengutronix.de>

2010/10/9 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:

Show 16 quoted lines

> Hi Bert,
>
> On Fri, Oct 08, 2010 at 09:57:59AM +0200, Bert Wesarg wrote:
>> This changes the way how cat_file selects the source of the file. It
>> accepts an optional parameter which is either -i or -w and will react on this
>> instead of the branch name. tg-patch is updated accordingly and can now
>> accepts the current branch name as argument with -i or -w given.
>>
>> cat_file was also broken for the worktree case when we are not in the top level.
>>
>> Also, tg-patch allowed to be on the top-base branch, but -i and -w doesn't
>> make sense there too.
>>
>> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> doesn't apply anymore.  Do you care to fix and resend?  I think it's
> your own change to cat_file BTW ... :-)

Right, Sorry. I should have done a git fetch. Will resend now.

Show 15 quoted lines

>
>
>> ---
>>
>> I will probably never understand why TopGit accepts to be on a top-base branch.
> /me shrugs.
>
>> I will probably never understand why TopGit not changes the cwd to the top level.
> I can imagine that strange things can happen then, but I don't have an
> example.
>
>> I will probably never understand why TopGit does not use the git-sh-setup.sh.
> I'm not sure this works in all cases.  And I think it's not sensibe as
> we don't have control over this file.  And what if it starts providing a
> function with the same name as one of our's?

It does already: die.

Regards, Bert

>
> Best regards
> Uwe
>