git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [TopGit PATCH 01/10] cat_file: take -i/-w parameters

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Oct 9, 2010, 20:32 UTC
Message-ID
<20101009203219.GN29673@pengutronix.de>
In-Reply-To
<160b8b0eb6152da98f4fa633ac25c7a25ff32aa4.1286524446.git.bert.wesarg@googlemail.com>
Hi Bert,
On Fri, Oct 08, 2010 at 09:57:59AM +0200, Bert Wesarg wrote:
Show 11 quoted lines
> This changes the way how cat_file selects the source of the file. It
> accepts an optional parameter which is either -i or -w and will react on this
> instead of the branch name. tg-patch is updated accordingly and can now
> accepts the current branch name as argument with -i or -w given.
> 
> cat_file was also broken for the worktree case when we are not in the top level.
> 
> Also, tg-patch allowed to be on the top-base branch, but -i and -w doesn't
> make sense there too.
> 
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>

doesn't apply anymore. Do you care to fix and resend? I think it's your own change to cat_file BTW ... :-)

> ---
> 
> I will probably never understand why TopGit accepts to be on a top-base branch.
/me shrugs.
> I will probably never understand why TopGit not changes the cwd to the top level.

I can imagine that strange things can happen then, but I don't have an example.

> I will probably never understand why TopGit does not use the git-sh-setup.sh.

I'm not sure this works in all cases. And I think it's not sensibe as we don't have control over this file. And what if it starts providing a function with the same name as one of our's?

Best regards Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Previous: Bert WesargNext: Bert Wesarg
Message 15 of 16 in “cat_file: take -i/-w parameters”
  1. 01/10 cat_file: take -i/-w parametersBert Wesarg, Oct 8, 2010
  2. 02/10 pretty_tree: globalize and respect -i/-w optionsBert Wesarg, Oct 8, 2010
  3. 03/10 branch_empty: use pretty_tree and therefore respect -i/-wBert Wesarg, Oct 8, 2010
  4. 04/10 tg-path: use pretty_tree and diff-tree to generate the patchBert Wesarg, Oct 8, 2010
  5. 05/10 list_deps: accept -i/-wBert Wesarg, Oct 8, 2010
  6. 06/10 tg-summary: accept -i/-wBert Wesarg, Oct 8, 2010
  7. 07/10 tg-files: list files changed by the topic branchBert Wesarg, Oct 8, 2010
  8. 08/10 tg-prev/tg-next: commands to explore dependenciesBert Wesarg, Oct 8, 2010
  9. 09/10 [RFC] tg-patch: use ui diff when pager is activeBert Wesarg, Oct 8, 2010
  10. 10/10 [RFC] tg-patch: simulate mnemonic prefixesBert Wesarg, Oct 8, 2010
  11. Uwe Kleine-KönigOct 9, 2010
  12. Bert WesargOct 9, 2010
  13. Uwe Kleine-KönigOct 9, 2010
  14. Bert WesargOct 10, 2010
  15. Uwe Kleine-KönigOct 9, 2010
  16. Bert WesargOct 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.