Re: [PATCH] msvc: Fix compilation error due to missing mktemp() declaration
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Dec 24, 2010, 01:00 UTC
- Message-ID
- <AANLkTineKS2e8PJs76PLZP4L4APwX2kAiFPg4pz3esae@mail.gmail.com>
- In-Reply-To
- <4D139D91.8080503@ramsay1.demon.co.uk>
On Thu, Dec 23, 2010 at 8:05 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:
Show 12 quoted lines
> > Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed > the compat/vcbuild/include/dirent.h compatibility header file. > This file, among other things, included the <io.h> system header > file which provides the declaration of the mktemp() function. > > In order to fix the compilation error, we add an include directive > for <io.h> to the compat/vcbuild/include/unistd.h header. (The > MinGW build includes <io.h> from it's <unistd.h> header too.) > > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> > ---
Thanks. But shouldn't this header be included in mingw.h (or perhaps msvc.h) because of _get_osfhandle and _commit?