From: Erik Faye-Lund Date: Fri, 24 Dec 2010 01:00:26 GMT Subject: Re: [PATCH] msvc: Fix compilation error due to missing mktemp() declaration Message-ID: In-Reply-To: <4D139D91.8080503@ramsay1.demon.co.uk> On Thu, Dec 23, 2010 at 8:05 PM, Ramsay Jones wrote: > > Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed > the compat/vcbuild/include/dirent.h compatibility header file. > This file, among other things, included the system header > file which provides the declaration of the mktemp() function. > > In order to fix the compilation error, we add an include directive > for to the compat/vcbuild/include/unistd.h header. (The > MinGW build includes from it's header too.) > > Signed-off-by: Ramsay Jones > --- Thanks. But shouldn't this header be included in mingw.h (or perhaps msvc.h) because of _get_osfhandle and _commit?