git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add two grep config options

From
Joe Ratterman <jratt0@gmail.com>
Date
Mar 28, 2011, 14:48 UTC
Message-ID
<AANLkTin_qRH54C0wKML67gftS05X98sKE+AxHJ4xo77C@mail.gmail.com>
In-Reply-To
<AANLkTin_qeFSqyXHddmEpu=5e4yO8cxyOkbhcXUg3efn@mail.gmail.com>
On Mon, Mar 28, 2011 at 7:13 AM, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
Show 17 quoted lines
>
> On Mon, Mar 28, 2011 at 09:24, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
> > We could safeguard scripts from this by
> >
> > - checking istty and
>
> That should consider running under the pager too.
>
> I had proposed this scheme last year to TopGit as a way to
> differentiate between ui and plumbing. But as Jeff pointed out, this
> is probably not enough.
>
> Bert
>
> > - checking env for GIT_PLUMBING
> >

Thanks for looking over this and taking the time to comment. I had not considered the importance of the first line, nor had I noticed the lack of hyphens in the other options--I copied the name of grep.extended-regexp from the --extended-regexp grep option. I can change those things if the general idea is accepted. I like the idea of a single option config key have takes a list of command-line flags, but I'm not 100% sure I know enough about git code internals to implement it. I'll look.

With regard to disabling the line numbering, GNU grep supports both -n and --line-number. Adding the latter option to git grep allows for the long form --no-line-number. Another option would be to use -N for the negative, like -h and -H. GNU grep doesn't support either of those.

Thanks, Joe Ratterman

Previous: Bert WesargNext: Junio C Hamano
Message 12 of 19 in “Add two grep config options”
  1. Add two grep config optionsJoe Ratterman, Mar 25, 2011
  2. Junio C HamanoMar 25, 2011
  3. Michael J GruberMar 28, 2011
  4. Jeff KingMar 28, 2011
  5. Michael J GruberMar 28, 2011
  6. Jeff KingMar 28, 2011
  7. Junio C HamanoMar 28, 2011
  8. Jeff KingMar 28, 2011
  9. Junio C HamanoMar 28, 2011
  10. Joe RattermanMar 28, 2011
  11. Bert WesargMar 28, 2011
  12. Joe RattermanMar 28, 2011
  13. Junio C HamanoMar 28, 2011
  14. grep: allow -E and -n to be turned on by default via configurationJunio C Hamano, Mar 28, 2011
  15. Junio C HamanoMar 28, 2011
  16. Joe RattermanMar 28, 2011
  17. Junio C HamanoMar 28, 2011
  18. Joe RattermanMar 29, 2011
  19. grep: allow -E and -n to be turned on by default via configurationJoe Ratterman, Mar 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.