git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add two grep config options

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 28, 2011, 18:39 UTC
Message-ID
<7vy63zxf6v.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110328172122.GA20817@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> I dunno. I generally prefer to use extended regexps when I can, but I
> don't remember ever having been annoyed that they are not the default
> with git grep. Perhaps because 99% of my greps are for literal symbol
> names (whereas in my editor, I am often doing substitutions, and I am
> continually annoyed at having to use backslash to make my parentheses
> magical).

I do not think I've ever been annoyed that "GNU grep" needs -E to enable extended regexps, either.

As much as I hate GREP_OPTIONS and GREP_COLORS environment variables that force us to write a "sane_grep" wrapper to run "grep" while disabling these, I have to admit that the approach to use these environment variables is far easier to disable than having a set of configuration variables that cover many commands we have, which is harder to disable selectively.

Having discussed all this, with an addition of --[no-]line-number synonym to the existing -n option, I don't think this particular incompatibility is a huge issue. At the worst, we might want to wait until a version bump like 1.8.0, but I personally think a prominent notice in the release notes in 1.7.5 would be sufficient.

Previous: Jeff KingNext: Joe Ratterman
Message 9 of 19 in “Add two grep config options”
  1. Add two grep config optionsJoe Ratterman, Mar 25, 2011
  2. Junio C HamanoMar 25, 2011
  3. Michael J GruberMar 28, 2011
  4. Jeff KingMar 28, 2011
  5. Michael J GruberMar 28, 2011
  6. Jeff KingMar 28, 2011
  7. Junio C HamanoMar 28, 2011
  8. Jeff KingMar 28, 2011
  9. Junio C HamanoMar 28, 2011
  10. Joe RattermanMar 28, 2011
  11. Bert WesargMar 28, 2011
  12. Joe RattermanMar 28, 2011
  13. Junio C HamanoMar 28, 2011
  14. grep: allow -E and -n to be turned on by default via configurationJunio C Hamano, Mar 28, 2011
  15. Junio C HamanoMar 28, 2011
  16. Joe RattermanMar 28, 2011
  17. Junio C HamanoMar 28, 2011
  18. Joe RattermanMar 29, 2011
  19. grep: allow -E and -n to be turned on by default via configurationJoe Ratterman, Mar 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.