Re: [PATCH/RFC] Fix for default pager
- From
Dario Rodriguez <soft.d4rio@gmail.com>
- Date
- Jun 8, 2010, 17:28 UTC
- Message-ID
- <AANLkTinZSuXJEXzpvEavYNLSyqUlx8qzWlrbtIH6q6fx@mail.gmail.com>
- In-Reply-To
- <4C0E6810.3070301@viscovery.net>
On Tue, Jun 8, 2010 at 12:56 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 21 quoted lines
> Am 08.06.2010 16:39, schrieb Dario Rodriguez: >> >> On Tue, Jun 8, 2010 at 11:17 AM, Johannes Sixt<j.sixt@viscovery.net> >> wrote: >>> >>> $ GIT_PAGER=/is/not/there git log >>> $ echo $? >>> 141 >>> >>> That's SIGPIPE, just as I would expect. >> >> As I said in the original thread... >> >> $ PAGER=/nothing/here ../git log >> $ echo $? >> 0 > > That's no surprise with your toy repository: git-log has run to completion > (without overrunning the pipe buffer) before the pager process that it > forked can even execute its first instruction. >
I cannot understand what's the point... I'm running git without installing it, but why do you say "toy repository"?...
Show 20 quoted lines
>> btw: I still think 'more' is much more sane fallback default than >> 'less'... look (with your patch applied): >> >> $ ../git log >> error: cannot run less: No such file or directory >> commit 3274a12f940680612e3bfd3d022a0eab460c0f1f >> Author: #######<#######@Maquina01.(none)> >> Date: Thu Jun 3 20:02:23 2010 +0200 >> >> OtherCom >> >> commit acf110f7c878a37e4a5af8499134df28da0e8ab3 >> Author: #######<#######@Maquina01.(none)> >> Date: Thu Jun 3 20:01:37 2010 +0200 >> >> inicial >> > > How is this an argument for 'more'? (Just asking; I don't see your point.) >
No problem, let me explain: 'more' is older and standard while (correct me if not true) 'less' is not in POSIX:2008. I work in a lot of Unix-like systems and I found 'more' as a standard, while less is just sometimes installed... my error running 'less' is such an argument for 'more' because:
$ PAGER=more ../git log commit fccd640197e34dbff72954924ed5c76c42a4aac7 Author: ###### <######@Maquina01.(none)> Date: Tue Jun 8 19:23:23 2010 +0200
commit stdin: END
'more' is not a problem... and as a POSIX standard it's almost never a problem.