Re: [PATCH/RFC] Fix for default pager

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 8, 2010, 15:56 UTC
Message-ID: <4C0E6810.3070301@viscovery.net>
In-Reply-To: <AANLkTilWg8hw5j20o-xGsVO-q_OeSmtKEKAO6O416qvH@mail.gmail.com>

Am 08.06.2010 16:39, schrieb Dario Rodriguez:

Show 12 quoted lines

> On Tue, Jun 8, 2010 at 11:17 AM, Johannes Sixt<j.sixt@viscovery.net>  wrote:
>>   $ GIT_PAGER=/is/not/there git log
>>   $ echo $?
>>   141
>>
>> That's SIGPIPE, just as I would expect.
>
> As I said in the original thread...
>
> $ PAGER=/nothing/here ../git log
> $ echo $?
> 0

That's no surprise with your toy repository: git-log has run to completion (without overrunning the pipe buffer) before the pager process that it forked can even execute its first instruction.

Show 17 quoted lines

> btw: I still think 'more' is much more sane fallback default than
> 'less'... look (with your patch applied):
>
> $ ../git log
> error: cannot run less: No such file or directory
> commit 3274a12f940680612e3bfd3d022a0eab460c0f1f
> Author: #######<#######@Maquina01.(none)>
> Date:   Thu Jun 3 20:02:23 2010 +0200
>
>      OtherCom
>
> commit acf110f7c878a37e4a5af8499134df28da0e8ab3
> Author: #######<#######@Maquina01.(none)>
> Date:   Thu Jun 3 20:01:37 2010 +0200
>
>      inicial
>

How is this an argument for 'more'? (Just asking; I don't see your point.)

-- Hannes