Re: [PATCH 5/6] Introduce the git fast-import-helper

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Oct 3, 2010, 15:53 UTC
Message-ID: <AANLkTinZ6NCvKeALDBfP4z=ewkwWVwHBk=C_LmXM7OFh@mail.gmail.com>
In-Reply-To: <4CA8A504.50009@dbservice.com>

Heya,

On Sun, Oct 3, 2010 at 17:45, Tomas Carnecky <tom@dbservice.com> wrote:

> I agree. But when I started hacking on fast-import it seemed easier to
> completely rip out parts that I didn't need and then add the few bits
> that I needed.

Sure, that would indeed be easier, but so much less maintainable :).

> I only need two new things from fast-import:
>  1) support non-numeric marks (and even this is maybe not strictly
> required)

If this can be avoided, or worked around somehow, it would be a boon to performance. The current marks implementation uses a hash table index by the mark number, which is O(1), very efficient.

>  2) dump the mark->sha1 mapping immediately after creating the object
> (I heard there is a patch somewhere that does just that)

Why do you need that? Wouldn't the "write created object name to stdout" not be sufficient?

> All other changes are not needed. Though I think there are a few things
> which could be ported back to fast-import.c. I'll try to see which
> changes make sense to be backported and will post patches.

I'd be very interested in those :).

-- 
Cheers,

Sverre Rabbelier