Re: [PATCH 1/3] Set cmdline globally, not in stop_here_user_resolve
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jun 1, 2010, 09:36 UTC
- Message-ID
- <AANLkTinY8Z-Y_1aFnJrojaAMs68FITt-whC0fLbpIR8h@mail.gmail.com>
- In-Reply-To
- <4C04D268.6070908@viscovery.net>
Hi,
> Did you test this? "$0" prints the full path to git-am. This does not > count as user-friendly in my book!
Doesn't it print out exactly the way you invoke the application ie. either "./git-am.sh" or "git am"? Then again, when git-am is invoked internally by git, it possibly uses the full path instead of relying on $PATH, and this is quite ugly. I noticed that all the other other shell scripts in git.git also hardcode the string, and there must be a good reason for this. Therefore I think this particular change should be dropped.
Thanks for pointing this out.
-- Ram