git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] Set cmdline globally, not in stop_here_user_resolve

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 1, 2010, 09:20 UTC
Message-ID
<1275384022-12131-2-git-send-email-artagnon@gmail.com>
In-Reply-To
<1275384022-12131-1-git-send-email-artagnon@gmail.com>

Set the $cmdline variable globally, so it can be used in other code fragments as well. Also, instead of hardcoding the string "git am", use the command line argument "$0".

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 git-am.sh |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index 87ffae2..b779277 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -52,6 +52,16 @@ else
 	HAS_HEAD=
 fi
 
+cmdline="$0"
+if test '' != "$interactive"
+then
+    cmdline="$cmdline -i"
+fi
+if test '' != "$threeway"
+then
+    cmdline="$cmdline -3"
+fi
+
 sq () {
 	git rev-parse --sq-quote "$@"
 }
@@ -66,15 +76,6 @@ stop_here_user_resolve () {
 	    printf '%s\n' "$resolvemsg"
 	    stop_here $1
     fi
-    cmdline="git am"
-    if test '' != "$interactive"
-    then
-        cmdline="$cmdline -i"
-    fi
-    if test '' != "$threeway"
-    then
-        cmdline="$cmdline -3"
-    fi
     echo "When you have resolved this problem run \"$cmdline --resolved\"."
     echo "If you would prefer to skip this patch, instead run \"$cmdline --skip\"."
     echo "To restore the original branch and stop patching run \"$cmdline --abort\"."
-- 
1.7.1
Previous: Ramkumar RamachandraNext: Johannes Sixt
Message 2 of 7 in “Improve git-am error messages”
  1. 0/3 Improve git-am error messagesRamkumar Ramachandra, Jun 1, 2010
  2. 1/3 Set cmdline globally, not in stop_here_user_resolveRamkumar Ramachandra, Jun 1, 2010
  3. Johannes SixtJun 1, 2010
  4. Ramkumar RamachandraJun 1, 2010
  5. 2/3 Display some help text when patch is emptyRamkumar Ramachandra, Jun 1, 2010
  6. 3/3 Remove stray error message from sedRamkumar Ramachandra, Jun 1, 2010
  7. Junio C HamanoJun 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.