Re: [PATCHv7.1 3/4] gitweb: File based caching layer (from git.kernel.org)
- From
- demerphq <demerphq@gmail.com>
- Date
- Nov 29, 2010, 23:07 UTC
- Message-ID
- <AANLkTinX9Phu+SuOyEWtAsMz182VkfVkJva1ep==V-zQ@mail.gmail.com>
- In-Reply-To
- <201011130056.24222.jnareb@gmail.com>
2010/11/13 Jakub Narebski <jnareb@gmail.com>:
Show 12 quoted lines
> - binmode STDOUT, ':raw';
> - print <$fd>;
> - binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi
> + if ($caching_enabled) {
> + open BINOUT, '>', $fullhashbinpath or die_error(500, "Could not open bin dump file");
> + }else{
> + open BINOUT, '>', \$fullhashbinpath or die_error(500, "Could not open bin dump file");
> + }
> + binmode BINOUT, ':raw';
> + print BINOUT <$fd>;
> + binmode BINOUT, ':utf8'; # as set at the beginning of gitweb.cgi
> + close BINOUT;Why do you use dynamically scoped file handles here as opposed to lexically scoped ones?
And why do you change the output discipline on BINOUT immediately before closing the file, and after you print data to it?
Doing so sortof makes sense when the filedhandle is STDOUT, but not when it is BINOUT.
cheers, Yves
-- perl -Mre=debug -e "/just|another|perl|hacker/"