Re: [PATCHv7.2 4/4] gitweb: Minimal testing of gitweb caching
Jakub Narebski <jnareb@gmail.com> writes:
Show 5 quoted lines
> +gitweb_enable_caching () {
> + test_expect_success 'enable caching' '
> + cat >>gitweb_config.perl <<-\EOF &&
> + our $caching_enabled = 1;
> + our $minCacheTime = 60*60*24*7*30; # very long expiration time for tests (a month)Does your month have 210 days in it?
> + our $maxCacheTime = 60*60*24*7*30*365; # upper bound for dynamic (adaptive) caching
Likewise, is this 210 years? Does this bust 32-bit time_t somewhere?
> + our $cachedir = "cache"; # for testsuite to clear the right thing
> + # required, because otherwise some tests might intermittently not pass
> + our $backgroundCache = 0; # should turn off cacheWaitForUpdate() / "Generating..."
> + #our $cacheDoFork = 0;
Junio C Hamano <gitster@pobox.com>