Re: [PATCH 5/8] trace: factor out "do we want to trace" logic
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Feb 24, 2011, 15:07 UTC
- Message-ID
- <AANLkTinUa8kg9mZaqV2ZAz9fc==FSA+ja-5W3ydqqYOL@mail.gmail.com>
- In-Reply-To
- <20110224142859.GE15477@sigill.intra.peff.net>
On Thu, Feb 24, 2011 at 3:28 PM, Jeff King <peff@peff.net> wrote:
Show 9 quoted lines
> +int trace_want(const char *key)
> +{
> + const char *trace = getenv(key);
> +
> + if (!trace || !strcmp(trace, "") ||
> + !strcmp(trace, "0") || !strcasecmp(trace, "false"))
> + return 0;
> + return 1;
> +}Other minor nit: calling it "trace_wanted()" or "want_trace()" looks better to me.
Thanks, Christian.