Re: [PATCH 2/8] strbuf: add strbuf_addv
- From
Jeff King <peff@peff.net>
- Date
- Feb 24, 2011, 15:07 UTC
- Message-ID
- <20110224150736.GA24346@sigill.intra.peff.net>
- In-Reply-To
- <AANLkTi=cBkH5=fmH-k=Sid_4Pwzoa9A4T9z8dcMAjirL@mail.gmail.com>
On Thu, Feb 24, 2011 at 04:05:13PM +0100, Christian Couder wrote:
Show 9 quoted lines
> > + len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, cp);
> > + va_end(cp);
> > if (len < 0)
> > - die("your vsnprintf is broken");
> > + die("BUG: your vsnprintf is broken (returned -1)");
>
> Minor nit: why not:
>
> + die("BUG: your vsnprintf is broken (returned %d)", len);No reason. I'll switch to yours in my re-roll.
-Peff