Re: [PATCH 09/32] index: make narrow index incompatible with older git
On Wed, Aug 25, 2010 at 9:43 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 26 quoted lines
> Nguyễn Thái Ngọc Duy wrote:
>
>> Index in narrow repos is not a full index and should not be used
>> to create commits without modification (to be explained later on).
> [...]
>> +++ b/read-cache.c
>> @@ -25,8 +25,9 @@ static struct cache_entry *refresh_cache_entry(struct
>> cache_entry *ce, int reall
>> */
>>
>> #define CACHE_EXT(s) ( (s[0]<<24)|(s[1]<<16)|(s[2]<<8)|(s[3]) )
>> -#define CACHE_EXT_TREE 0x54524545 /* "TREE" */
>> +#define CACHE_EXT_TREE 0x54524545 /* "TREE" */
>> #define CACHE_EXT_RESOLVE_UNDO 0x52455543 /* "REUC" */
>> +#define CACHE_EXT_NARROW 0x4e415257 /* "NARW" */
>
> Just curious: why aren't we using
>
> #define CACHE_EXT_TREE CACHE_EXT("TREE")
> #define CACHE_EXT_RESOLVE_UNDO CACHE_EXT("REUC")
> #define CACHE_EXT_NARROW CACHE_EXT("NARW")
>
> Are they invalid case labels?
>
> I think non-optional extensions might need to be lowercase ("narw")
> though I am not sure.No idea. I need to dig into history to figure it out later.
--
Duy
Nguyen Thai Ngoc Duy <pclouds@gmail.com>