Re: [PATCH 11/32] rev-list: support --narrow-tree

From: Elijah Newren <newren@gmail.com>
Date: Aug 25, 2010, 03:59 UTC
Message-ID: <AANLkTi=KBThiZ_FBUh0RfzLtP=YAtUPcx5PJW1q5OCd4@mail.gmail.com>
In-Reply-To: <1282688422-7738-12-git-send-email-pclouds@gmail.com>

Hi,

2010/8/24 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:

> These options allow plumbing to access narrow tree traverse modes.
> As a consequence, tests can now be written to test these modes.
>

<snip>

Show 5 quoted lines

> +                       if (!prefixcmp(arg, "--narrow-tree=")) {
> +                               revs->narrow_prefix = arg + 14;
> +                               revs->narrow_tree = 1;
> +                               continue;
> +                       }

Seems somewhat non-gittish. Why not 'git rev-list --objects HEAD -- <subtree_path>' rather than 'git rev-list --objects --narrow-tree=<subtree_path> HEAD'? (Was it due to the current bug in rev-list when specifying both --objects and paths? If so, that's addressed in the patch series I just sent.)

Show 6 quoted lines

> +cat <<EOF >merge.expected
> +0da28f8308e336bd4b2c26b61c7fc44e41a30e49
> +7475cb8a389b36ce238b9ee6cbfdfa26a1b67e35
> +af9c31c0e217154296d93d66b9a5a41892c7b321
> +ba7a30916c792624a8372cb26da50f5594098222
> +74a398027f0b59183db54ca8c67dc30b5aeed0ff t2

Is this right?  Do you expect to see a t2 entry when filtering for t1/t12?

Show 15 quoted lines

> +3b52e9990a52d9ea46b25199b5810566324759f4
> +fa0bba1767985729582729a12a5459cd041d6cf6 t1
> +d81015b2a1c40fc6cbc5bf5a8b16949018c3aede t1/t12
> +52bd8e43afb01d0c9747f1fedf2fc94684ee4cc4 t1/t12/f120
> +aa0602ee56ea4cb5e5bfff8713bb8a9a6ab4303e
> +d77d258d806b2aa7cdb5a301e6a54f023d9bdcfe t1
> +ab246f7eb05e94f695d2a0e30093d94fde7b837e t1/t12
> +04156ae83e615fa5b6019170928bc131539f9996 t1/t12/f120
> +72e05e456b9ff4c01ccf6178ce60d9b52b41aae4
> +4fc1656b01ce8b21987c55a2870b8c9a431ec772 t1
> +EOF
> +
> +test_expect_success 'rev-list --narrow-tree=t1/t12 with merges' '
> +       git rev-list --objects --narrow-tree=t1/t12 $MERGE >result &&
> +       test_cmp merge.expected result