Re: [PATCH 6/7] tag: support column output with --column

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Feb 10, 2011, 02:35 UTC
Message-ID: <AANLkTinHyX+uiO+Oj3N3NAEjbZmE=vbKsA+C+tQ6B-Db@mail.gmail.com>
In-Reply-To: <7vvd0sop15.fsf@alter.siamese.dyndns.org>

2011/2/10 Junio C Hamano <gitster@pobox.com>:

Show 11 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> @@ -52,7 +54,7 @@ static int show_reference(const char *refname, const unsigned char *sha1,
>>               }
>>
>>               if (!filter->lines) {
>> -                     printf("%s\n", refname);
>> +                     string_list_append(&layout.items, refname);
>
> Hmm, is this robbing streaming output from people who do not care about
> columnar output?

Yes, but tag list is short enough streaming does not really matter. I can check if column mode is active there, if it's not, just printf.

> I tend to agree with others who suggested you to port column to platforms
> that lack it.

The first version of this series created git-column and made a pipe to git-column when column output is active. I'll resurrect the command then. Original column does not understand ANSI escape codes for coloring and mess up column output.

-- 
Duy