Re: [PATCH 6/7] tag: support column output with --column
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2011, 21:51 UTC
- Message-ID
- <7vvd0sop15.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1297178541-31124-7-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 6 quoted lines
> @@ -52,7 +54,7 @@ static int show_reference(const char *refname, const unsigned char *sha1,
> }
>
> if (!filter->lines) {
> - printf("%s\n", refname);
> + string_list_append(&layout.items, refname);Hmm, is this robbing streaming output from people who do not care about columnar output?
I tend to agree with others who suggested you to port column to platforms that lack it.