Re: [PATCH] pack-object: trim memory usage a tiny bit
On Sat, Aug 7, 2010 at 10:18 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 10 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
>>
>> Ah, by packing it tighter using bitfields. There are two fields that
>> act as boolean, but they use at least one byte each. And enum
>> object_type, I recall, uses 4 bytes (int), while it only needs 5 bits
>> (4 bits is enough if OBJ_BAD is not counted). No downsides I know of.
>
> Actually, object type is 3 bits in the pack file. So unless its
> using some additional magical values, 4 bits is sufficient to get
> you 3 bits and the -1 bad value.
Right. Obviously I miscounted.
--
Duy
Nguyen Thai Ngoc Duy <pclouds@gmail.com>