Re: [PATCH] pack-object: trim memory usage a tiny bit

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 7, 2010, 00:18 UTC
Message-ID: <20100807001829.GQ25268@spearce.org>
In-Reply-To: <AANLkTimEFjRuuO+GnAV7PGe0oPi-Qh37iLS6o3Q8Undw@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:

Show 5 quoted lines

> 
> Ah, by packing it tighter using bitfields. There are two fields that
> act as boolean, but they use at least one byte each. And enum
> object_type, I recall, uses 4 bytes (int), while it only needs 5 bits
> (4 bits is enough if OBJ_BAD is not counted). No downsides I know of.

Actually, object type is 3 bits in the pack file. So unless its using some additional magical values, 4 bits is sufficient to get you 3 bits and the -1 bad value.

-- 
Shawn.