git calls SSH_ASKPASS even if DISPLAY is not set
- From
- Xin Wang <dram.wang@gmail.com>
- Date
- Dec 11, 2010, 03:24 UTC
- Message-ID
- <AANLkTinES5dqt+JAMOrp7gAYJ4UgK9ipfEN9ag5qSCLp@mail.gmail.com>
Hi all,
I'm using git 1.7.3.2 in Fedora 14. In Fedora, SSH_ASKPASS will set to be /usr/libexec/openssh/gnome-ssh-askpass in /etc/profile.d/gnome-ssh-askpass.sh, so this environment is set by login shell, and it will still be set even when X11 is not inuse.
According to ssh's manpage: "If ssh does not have a terminal associated with it but DISPLAY and SSH_ASKPASS are set, it will execute the program specified by SSH_ASKPASS and open an X11 window to read the passphrase." But git will call SSH_ASKPASS even if there is a terminal associated with it and DISPLAY is not set, then following warning is displayed and git failed to go through.
$ git fetch
(gnome-ssh-askpass:1487): Gtk-WARNING **: cannot open display:
I think it‘s better if git could implement behavior conforming to ssh.
Thanks, Xin Wang