git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH] git_getpass: fix ssh-askpass behaviour

From
hvoigt <hvoigt@hvoigt.net>
Date
Dec 13, 2010, 22:00 UTC
Message-ID
<20101213220003.GB2497@sandbox>
In-Reply-To
<7voc8q7bdv.fsf@alter.siamese.dyndns.org>
Hi,
On Sun, Dec 12, 2010 at 04:41:00PM -0800, Junio C Hamano wrote:
Show 12 quoted lines
> Alexander Sulfrian <alexander@sulfrian.net> writes:
> 
> > call ssh-askpass only if the display environment variable is also set
> > ---
> 
> I do not use it at all so I don't know for sure, but doesn't this break
> OSX?
> 
>   20f3490 (web--browse: fix Mac OS X GUI detection for 10.6, 2009-09-14)
> 
> is an example that you can be fully graphical without having DISPLAY set
> in some environment.  MinGW folks may want to chime in as well.

I am not sure about OSX because I just checked and there seems to be a DISPLAY variable set which seems to be used to start a X session on demand. But MinGW definitely has no DISPLAY variable set by default.

Additionally GIT_ASKPASS/SSH_ASKPASS does not have to be a graphical tool does it? It could also be some program that looks up the password from some secure database.

Cheers Heiko
Previous: Junio C HamanoNext: Johannes Sixt
Message 6 of 8 in “git calls SSH_ASKPASS even if DISPLAY is not set”
  1. Xin WangDec 11, 2010
  2. RE: git calls SSH_ASKPASS even if DISPLAY is not setAlexander Sulfrian, Dec 12, 2010
  3. git_getpass: fix ssh-askpass behaviourAlexander Sulfrian, Dec 12, 2010
  4. Alexander SulfrianDec 12, 2010
  5. Junio C HamanoDec 13, 2010
  6. hvoigtDec 13, 2010
  7. Johannes SixtDec 13, 2010
  8. LarryMartellMay 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.