Re: [PATCHv4 1/2] daemon: add helper function named_sock_setup

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Aug 30, 2010, 12:58 UTC
Message-ID: <AANLkTinE2aqRqTLvmxFEuDLd1WBCOzr0GfP64DjPsdPL@mail.gmail.com>
In-Reply-To: <20100830144631.23d1a164@laptop.localhost>

On Mon, Aug 30, 2010 at 2:46 PM, AlexanderS <alexander@sulfrian.net> wrote:

Show 12 quoted lines

> On Mon, 30 Aug 2010 14:12:52 +0200
> Erik Faye-Lund <kusmabite@gmail.com> wrote:
>
>> Since serve() isn't a library function, wouldn't it reduce needless
>> code churn to just make socklist a set of global variables (or just a
>> global struct)? That way you don't have to pass it around, changing
>> all those function prototypes.
>
> I don't understand: Even if I make socklist a global structure or
> something like that, I also have to change all this function prototypes
> to remove at least the old unused parameters.
>

You are of course right, strike my comment :)