git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 1/2] daemon: add helper function named_sock_setup

From
AlexanderS <alexander@sulfrian.net>
Date
Aug 30, 2010, 12:46 UTC
Message-ID
<20100830144631.23d1a164@laptop.localhost>
In-Reply-To
<AANLkTindaa-wDkOMW=BgtNJ+Wmi3xaBo1o_CF7NFH=Qm@mail.gmail.com>

On Mon, 30 Aug 2010 14:12:52 +0200 Erik Faye-Lund <kusmabite@gmail.com> wrote:

> Since serve() isn't a library function, wouldn't it reduce needless
> code churn to just make socklist a set of global variables (or just a
> global struct)? That way you don't have to pass it around, changing
> all those function prototypes.

I don't understand: Even if I make socklist a global structure or something like that, I also have to change all this function prototypes to remove at least the old unused parameters.

> I'm a bit intimidated by this change since I have a rather big
> patch-set on top of daemon.c, and I really don't want to resolve a lot
> of conflicts. But I guess that's my problem :P
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 12 of 18 in “added possibility to supply more than one --listen argument to git-daemon”
  1. Alexander SulfrianAug 23, 2010
  2. added possibility to supply more than one --listen argument to git-daemonAlexander Sulfrian, Aug 23, 2010
  3. Junio C HamanoAug 23, 2010
  4. daemon: allow more than one host addresses given via --listenAlexander Sulfrian, Aug 29, 2010
  5. daemon: allow more than one host addresses given via --listenAlexander Sulfrian, Aug 29, 2010
  6. 1/2 daemon: add helper function named_sock_setupAlexander Sulfrian, Aug 29, 2010
  7. 2/2 daemon: allow more than one host address given via --listenAlexander Sulfrian, Aug 29, 2010
  8. Junio C HamanoAug 30, 2010
  9. daemon: allow more than one host address given via --listenAlexander Sulfrian, Aug 30, 2010
  10. 1/2 daemon: add helper function named_sock_setupAlexander Sulfrian, Aug 30, 2010
  11. Erik Faye-LundAug 30, 2010
  12. AlexanderSAug 30, 2010
  13. Erik Faye-LundAug 30, 2010
  14. 2/2 daemon: allow more than one host address given via --listenAlexander Sulfrian, Aug 30, 2010
  15. 1/2 daemon: add helper function named_sock_setupAlexander Sulfrian, Aug 29, 2010
  16. 2/2 daemon: allow more than one host address given via --listenAlexander Sulfrian, Aug 29, 2010
  17. Erik Faye-LundAug 29, 2010
  18. AlexanderSAug 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.