Re: Example git hooks (Re: Odd results writing a Git pre-receive hook to syntax check PHP files.)
- From
- Chris Patti <cpatti@gmail.com>
- Date
- Aug 31, 2010, 13:11 UTC
- Message-ID
- <AANLkTin8ZB8phz9J0TQwNoC4t4TZYz5PKW=yrhiV7i+1@mail.gmail.com>
- In-Reply-To
- <20100831015712.GT4925@inocybe.localdomain>
On Mon, Aug 30, 2010 at 9:57 PM, Todd Zullinger <tmz@pobox.com> wrote:
Show 35 quoted lines
> Jonathan Nieder wrote: >> Chris Patti wrote: >> >>> (P.S. Is there a canonical 'example Git hooks' location I could >>> publish this to when it's working? I think there's a dearth of this >>> kind of example for people out there right now) >> >> Try the git wiki (git.wiki.kernel.org). There is a page for aliases >> but no page for example hooks yet (though there are some examples >> under InterfacesFrontendsAndTools). You could be the trailblazer. >> >> There are also a few examples in git templates/ and contrib/hooks, >> of course. > > This reminds me a little of a discussion that came up a while back > regarding syntax checking of puppet manifests. The resulting hook is > here: > > http://projects.puppetlabs.com/projects/puppet/wiki/Puppet_Version_Control#Git+Update+Hook > > The git list discussion: > > http://thread.gmane.org/gmane.comp.version-control.git/118626 > > Dunno if that'll help you at all or not Chris. Hopefully it doesn't > hurt at least. :) > > -- > Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Every side I get up on is the wrong side of bed. > If it weren't so expensive, I'd wish I were dead. > -- signed Unhappy > >
An interesting example, thanks for that!
What's interesting is that it also evidences another characteristic I saw in a hook someone wrote here - they treat old_sha1 being 000000000 as a deletion, but I'm also seeing that when the hook is invoked on the first push in a new branch (Which makes sense since there is no old_sha1) but it makes me wonder if people are unaware of an implicit bug - in this case, all such pushes are skipped and not checked, so this means that someone can check in broken Puppet code if they are the first ones to do so on a new branch.
-Chris
-- Christopher Patti - Geek At Large | GTalk: cpatti@gmail.com | AIM: chrisfeohpatti | P: (260) 54PATTI "Technology challenges art, art inspires technology." - John Lasseter, Pixar