Re: Odd results writing a Git pre-receive hook to syntax check PHP files.

> Chris Patti <cpatti@gmail.com> writes:
>
>> function parseCommit($old_sha1,$new_sha1) {
>>         # if this is the first commit on a new branch, $old_sha1 will
>> be a bunch of zeroes, and so
>>         # git diff --raw will fail, since there's no old ref to
>> compare against.  So, we parse the
>>         # results of git diff-tree -root=$new_sha1 instead to get the
>> blob and filename we'll need.
>>         if (detectNewBranch($old_sha1,$new_sha1)) {
>>                 $diffcmd="git diff-tree --root $new_sha1";
>
> This somehow feels wrong.  If the tree of the new commit is flat without
> subdirectory, the above would do, but don't you need "diff-tree -r" here?
>