git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Convert the users for of for_each_string_list to string_list_for_each

From
Thiago Farina <tfransosi@gmail.com>
Date
Jul 2, 2010, 21:08 UTC
Message-ID
<AANLkTin6vHhkT7Q4h5A1g3OOQYzEPdVIOCWVyzxPacnS@mail.gmail.com>
In-Reply-To
<AANLkTimYyHtjCfRtrTgVh3LJeJQeBpdXMRsf3khKatFx@mail.gmail.com>
On Tue, Jun 29, 2010 at 5:37 AM, Alex Riesen <raa.lkml@gmail.com> wrote:
> The macro is suitable for all these cases
"all these cases" is too vague. Which cases?
> and will reduce code of
> need to just iterate over the items of a string list.
>
A minor comment. There is a typo in the subject:
string_list_for_each -> string_list_foreach.

Also, you didn't convert all the cases. There are usages of for_each_string_list under builtin/ directory too (I assume it was intentional).

Previous: Alex RiesenNext: Alex Riesen
Message 3 of 4 in “Convert the users for of for_each_string_list to string_list_for_each”
  1. 2/2 Convert the users for of for_each_string_list to string_list_for_eachAlex Riesen, Jun 29, 2010
  2. 2/2 Convert the users for of for_each_string_list to string_list_for_eachAlex Riesen, Jul 2, 2010
  3. Thiago FarinaJul 2, 2010
  4. Alex RiesenJul 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.