From: Thiago Farina <tfransosi@gmail.com>
Date: Fri, 02 Jul 2010 21:08:51 GMT
Subject: Re: [PATCH 2/2] Convert the users for of for_each_string_list to string_list_for_each
Message-ID: <AANLkTin6vHhkT7Q4h5A1g3OOQYzEPdVIOCWVyzxPacnS@mail.gmail.com>
In-Reply-To: <AANLkTimYyHtjCfRtrTgVh3LJeJQeBpdXMRsf3khKatFx@mail.gmail.com>

On Tue, Jun 29, 2010 at 5:37 AM, Alex Riesen <raa.lkml@gmail.com> wrote:
> The macro is suitable for all these cases

"all these cases" is too vague. Which cases?

> and will reduce code of
> need to just iterate over the items of a string list.
>
A minor comment. There is a typo in the subject:

string_list_for_each -> string_list_foreach.

Also, you didn't convert all the cases. There are usages of
for_each_string_list under builtin/ directory too (I assume it was
intentional).