Re: What's cooking in git.git (Jun 2010, #01; Wed, 2)

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Jun 3, 2010, 03:13 UTC
Message-ID: <AANLkTimuTIugURlYxwbk7wGW2IM11YTy4P91YDguLQUb@mail.gmail.com>
In-Reply-To: <7v4ohlatwn.fsf@alter.siamese.dyndns.org>

Hi,

On Thu, Jun 3, 2010 at 7:36 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> [New Topics]
> [snip]
> * tc/commit-abbrev-fix (2010-05-27) 3 commits
>  - commit::print_summary(): set rev_info.always_show_header to 1
>  - t7502-commit: add summary output tests for empty and merge commits
>  - t7502-commit: add tests for summary output
>
> Will merge to 'next'.  I am not quite happy about the "impossible to
> trigger" die message, though.  It is a good defensive programming to catch
> breakages caused by future changes that may invalidate the assumption this
> patch makes, but then the message should be worded as such to state that
> assumption, I think.

I'll try to remember to re-send the third patch with your suggestion about the message.

Show 12 quoted lines

> [Cooking]
> [snip]
> * tc/merge-m-log (2010-05-11) 8 commits
>  (merged to 'next' on 2010-05-21 at e889876)
>  + merge: --log appends shortlog to message if specified
>  + fmt-merge-msg: add function to append shortlog only
>  + fmt-merge-msg: refactor merge title formatting
>  + fmt-merge-msg: minor refactor of fmt_merge_msg()
>  + merge: rename variable
>  + merge: update comment
>  + t7604-merge-custom-message: show that --log doesn't append to -m
>  + t7604-merge-custom-message: shift expected output creation

FWIW, I've been using this feature for as long as it's been cooking - no issues thus far.

-- 
Cheers,
Ray Chuan