git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jun 2010, #01; Wed, 2)

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jun 4, 2010, 21:18 UTC
Message-ID
<20100604211811.GA7471@progeny.tock>
In-Reply-To
<7v4ohlatwn.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> * gv/portable (2010-05-14) 18 commits
[...]
>  - Do not use "diff" found on PATH while building and installing

That patch (d1b1a919) breaks merge-one-file when run outside the test suite as far as I can tell.

Maybe it could be made portable with ‘git diff --no-index’?
diff --git a/git-merge-one-file.sh b/git-merge-one-file.sh
index 3145009..d067894 100755
--- a/git-merge-one-file.sh
+++ b/git-merge-one-file.sh
@@ -107,7 +107,7 @@ case "${1:-.}${2:-.}${3:-.}" in
 		# remove lines that are unique to ours.
 		orig=`git-unpack-file $2`
 		sz0=`wc -c <"$orig"`
-		$DIFF -u -La/$orig -Lb/$orig $orig $src2 | git apply --no-add
+		diff -u -La/$orig -Lb/$orig $orig $src2 | git apply --no-add
 		sz1=`wc -c <"$orig"`
 
 		# If we do not have enough common material, it is not
Previous: Eyvind BernhardsenNext: Junio C Hamano
Message 19 of 23 in “What's cooking in git.git (Jun 2010, #01; Wed, 2)”
  1. Junio C HamanoJun 2, 2010
  2. Tay Ray ChuanJun 3, 2010
  3. 3/3 commit::print_summary(): set rev_info.always_show_header to 1Tay Ray Chuan, Jun 4, 2010
  4. Tay Ray ChuanJun 4, 2010
  5. Junio C HamanoJun 5, 2010
  6. commit::print_summary(): set rev_info.always_show_header to 1Tay Ray Chuan, Jun 7, 2010
  7. Michael J GruberJun 3, 2010
  8. mg/rev-parse-option-sifter-deprecationJonathan Nieder, Jun 3, 2010
  9. 1/2 separate quoting and relative path generationClemens Buchacher, Jun 3, 2010
  10. 2/2 ls-files: allow relative pathspecClemens Buchacher, Jun 3, 2010
  11. Junio C HamanoJun 3, 2010
  12. optimize path_relative()Clemens Buchacher, Jun 4, 2010
  13. Clemens BuchacherJun 4, 2010
  14. setup: document prefixClemens Buchacher, Jun 5, 2010
  15. optimize path_relative()Clemens Buchacher, Jun 5, 2010
  16. Junio C HamanoJun 5, 2010
  17. Thomas RastJun 3, 2010
  18. Eyvind BernhardsenJun 3, 2010
  19. Jonathan NiederJun 4, 2010
  20. Junio C HamanoJun 5, 2010
  21. Jonathan NiederJun 5, 2010
  22. Sverre RabbelierJun 5, 2010
  23. Junio C HamanoJun 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.