git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Allow HTTP user agent string to be modified.

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 7, 2010, 17:39 UTC
Message-ID
<AANLkTimsYJxvHZkj8DNyOLozA4HJ9cwo+v3G_r2UXWz-@mail.gmail.com>
In-Reply-To
<1281202184.4815.1.camel@compaq.olson.home>
On Sat, Aug 7, 2010 at 17:29, Spencer E. Olson <olsonse@umich.edu> wrote:
> I would have no problem doing that.  I was just trying to match the
> style already present in http.c.  All the other pointer tests in that
> function/file are done the same.

Ah, fair enough. I didn't notice that the rest of http.c already used that style, nevermind then.

It's best to just keep it consistent, and maybe clean it up in some later patch, but best not to introduce an inconsistency by using a different style just for this one.

Your patch looks good.
Previous: Spencer E. OlsonNext: Tay Ray Chuan
Message 4 of 14 in “Allow HTTP user agent string to be modified.”
  1. Allow HTTP user agent string to be modified.Spencer E. Olson, Aug 7, 2010
  2. Ævar Arnfjörð BjarmasonAug 7, 2010
  3. Spencer E. OlsonAug 7, 2010
  4. Ævar Arnfjörð BjarmasonAug 7, 2010
  5. Tay Ray ChuanAug 8, 2010
  6. Tay Ray ChuanAug 8, 2010
  7. Spencer E. OlsonAug 8, 2010
  8. Allow HTTP user agent string to be modified.Spencer E. Olson, Aug 11, 2010
  9. Tay Ray ChuanAug 11, 2010
  10. Junio C HamanoAug 11, 2010
  11. Allow HTTP user agent string to be modified.Spencer E. Olson, Aug 11, 2010
  12. Jacob HelwigAug 11, 2010
  13. Allow HTTP user agent string to be modified.Spencer E. Olson, Aug 11, 2010
  14. Junio C HamanoAug 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.