git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: cherry-pick / pre-commit hook?

From
Dave Abrahams <dave@boostpro.com>
Date
Dec 27, 2010, 21:33 UTC
Message-ID
<AANLkTimhMa+zGp+MNi9fjwNsAaMWz3VG=KERoDo7c0zA@mail.gmail.com>
In-Reply-To
<7vipyfx79g.fsf@alter.siamese.dyndns.org>
On Mon, Dec 27, 2010 at 11:58 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Dave Abrahams wrote:
>>
>>> if you're going to have a "pre-commit hook" concept,
>>> but not run that hook for some kinds of commits, then that fact needs
>>> to be documented.
>>
>> True, and thanks for a reminder.  Suggested wording?
>>
>> The current githooks(5) says
>>
>>  pre-commit
>>       This hook is invoked by git commit, and can be bypassed with
>>       --no-verify option.
>>
>> and leaves the question of whether it is invoked by git cherry-pick
>> unanswered.
>
> Huh?  Isn't it very clear that "git commit" calls it and "git status" or
> anything that is not "git commit" doesn't?
Not to me.  And is it really true?  What about rebase?  What about merge?
-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 11 in “cherry-pick / pre-commit hook?”
  1. Dave AbrahamsDec 8, 2010
  2. Jonathan NiederDec 8, 2010
  3. Dave AbrahamsDec 8, 2010
  4. Jonathan NiederDec 8, 2010
  5. Dave AbrahamsDec 27, 2010
  6. Jonathan NiederDec 27, 2010
  7. Junio C HamanoDec 27, 2010
  8. Dave AbrahamsDec 27, 2010
  9. Junio C HamanoDec 28, 2010
  10. Jakub NarebskiDec 28, 2010
  11. Dave AbrahamsDec 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.