From: Dave Abrahams <dave@boostpro.com>
Date: Mon, 27 Dec 2010 21:33:27 GMT
Subject: Re: cherry-pick / pre-commit hook?
Message-ID: <AANLkTimhMa+zGp+MNi9fjwNsAaMWz3VG=KERoDo7c0zA@mail.gmail.com>
In-Reply-To: <7vipyfx79g.fsf@alter.siamese.dyndns.org>

On Mon, Dec 27, 2010 at 11:58 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Dave Abrahams wrote:
>>
>>> if you're going to have a "pre-commit hook" concept,
>>> but not run that hook for some kinds of commits, then that fact needs
>>> to be documented.
>>
>> True, and thanks for a reminder.  Suggested wording?
>>
>> The current githooks(5) says
>>
>>  pre-commit
>>       This hook is invoked by git commit, and can be bypassed with
>>       --no-verify option.
>>
>> and leaves the question of whether it is invoked by git cherry-pick
>> unanswered.
>
> Huh?  Isn't it very clear that "git commit" calls it and "git status" or
> anything that is not "git commit" doesn't?

Not to me.  And is it really true?  What about rebase?  What about merge?

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com