Re: [PATCH] enable "no-done" extension only when fetching over smart-http

From: Shawn Pearce <spearce@spearce.org>
Date: Mar 29, 2011, 17:24 UTC
Message-ID: <AANLkTimg5_9dQDq8Xa9pJsx9f6UrNewih+WirKcOP42i@mail.gmail.com>
In-Reply-To: <7vlizxsv82.fsf@alter.siamese.dyndns.org>

On Tue, Mar 29, 2011 at 10:16, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> When 'no-done' protocol extension is used, the upload-pack (i.e. the
> server side) process stops listening to the fetch-pack after issuing the
> final NAK, and starts sending the generated pack data back, but there may
> be more "have" send by the latter in flight that the fetch-pack is
> expecting to be responded with ACK/NAK.  This will typically result in a
> deadlock (both will block on write that the other end never reads) or
> SIGPIPE on the fetch-pack end (upload-pack will finish writing a small
> pack and goes away).
>
> Disable it unless fetch-pack is running under smart-http, where there is
> no such streaming issue.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Acked-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.