From: Shawn Pearce Date: Tue, 29 Mar 2011 17:24:12 GMT Subject: Re: [PATCH] enable "no-done" extension only when fetching over smart-http Message-ID: In-Reply-To: <7vlizxsv82.fsf@alter.siamese.dyndns.org> On Tue, Mar 29, 2011 at 10:16, Junio C Hamano wrote: > When 'no-done' protocol extension is used, the upload-pack (i.e. the > server side) process stops listening to the fetch-pack after issuing the > final NAK, and starts sending the generated pack data back, but there may > be more "have" send by the latter in flight that the fetch-pack is > expecting to be responded with ACK/NAK.  This will typically result in a > deadlock (both will block on write that the other end never reads) or > SIGPIPE on the fetch-pack end (upload-pack will finish writing a small > pack and goes away). > > Disable it unless fetch-pack is running under smart-http, where there is > no such streaming issue. > > Signed-off-by: Junio C Hamano Acked-by: Shawn O. Pearce -- Shawn.