Re: [PATCH] fixes for ActiveState Perl

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Feb 14, 2011, 19:48 UTC
Message-ID: <AANLkTimb2puTjj=DDqJcshwSVgqebhS9__jHoY1KdO_7@mail.gmail.com>
In-Reply-To: <4D5984DD.1030004@io.com>

On Mon, Feb 14, 2011 at 8:39 PM, Rafael Kitover <rkitover@io.com> wrote:

Show 36 quoted lines

> On 2/14/2011 7:49 AM, Erik Faye-Lund wrote:
> ...
>>> diff --git a/perl/Makefile b/perl/Makefile
>>> index a2ffb64..1fa99cd 100644
>>> --- a/perl/Makefile
>>> +++ b/perl/Makefile
>>> @@ -3,18 +3,28 @@
>>>  #
>>>  makfile:=perl.mak
>>>
>>> +# support PERL_PATH=C:\\Perl\\bin\\perl
>>> +PERL_PATH := $(subst \,\\,$(PERL_PATH))
>>> +
>>>  PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
>>> +PERL_MAKE := MAKEFLAGS="" $(subst \,\\,$(shell $(subst \,\\,$(PERL_PATH)) -MConfig -le "print ((\%Config)->{make})"))
>>> +
>>> +ifneq (,$(findstring nmake,$(PERL_MAKE)))
>>> +       PERL_MAKE := $(PERL_MAKE) -nologo
>>> +endif
>>> +
>>>  prefix_SQ = $(subst ','\'',$(prefix))
>>>
>>>  ifndef V
>>>        QUIET = @
>>>  endif
>>>
>>> +
>>
>> Why?
>
> Windows perl (activestate, strawberry) uses nmake or dmake. The
> makefiles for these makes are incompatible with GNU make. This code
> retrieves the make Perl would use from its Config, and uses that on
> invoking perl.mak .
>
> This should also allow for using EU::MM for the MSVC+ActiveState build.

I'm sorry for not being clear; I was talking about that single new-line, not the PERL_MAKE-stuff.