Re: [PATCH] fixes for ActiveState Perl

From: Rafael Kitover <rkitover@io.com>
Date: Feb 14, 2011, 19:39 UTC
Message-ID: <4D5984DD.1030004@io.com>
In-Reply-To: <AANLkTimCXEbzZnR1k32u942hjB37nThN_RDBL5N7owHa@mail.gmail.com>

On 2/14/2011 7:49 AM, Erik Faye-Lund wrote: ...

Show 27 quoted lines

>> diff --git a/perl/Makefile b/perl/Makefile
>> index a2ffb64..1fa99cd 100644
>> --- a/perl/Makefile
>> +++ b/perl/Makefile
>> @@ -3,18 +3,28 @@
>>  #
>>  makfile:=perl.mak
>>
>> +# support PERL_PATH=C:\\Perl\\bin\\perl
>> +PERL_PATH := $(subst \,\\,$(PERL_PATH))
>> +
>>  PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
>> +PERL_MAKE := MAKEFLAGS="" $(subst \,\\,$(shell $(subst \,\\,$(PERL_PATH)) -MConfig -le "print ((\%Config)->{make})"))
>> +
>> +ifneq (,$(findstring nmake,$(PERL_MAKE)))
>> +       PERL_MAKE := $(PERL_MAKE) -nologo
>> +endif
>> +
>>  prefix_SQ = $(subst ','\'',$(prefix))
>>
>>  ifndef V
>>        QUIET = @
>>  endif
>>
>> +
> 
> Why?

Windows perl (activestate, strawberry) uses nmake or dmake. The makefiles for these makes are incompatible with GNU make. This code retrieves the make Perl would use from its Config, and uses that on invoking perl.mak .

This should also allow for using EU::MM for the MSVC+ActiveState build.