git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags.

From
Jon Seymour <jon.seymour@gmail.com>
Date
Sep 25, 2010, 16:19 UTC
Message-ID
<AANLkTimW6shzyLqW-Ok_+kopjnq5t+AVxW0WRrmjkgQp@mail.gmail.com>
In-Reply-To
<AANLkTimj--jZdX++=ZjF3A0HE11FbkgVb2gs3ADVEGvx@mail.gmail.com>

On Sun, Sep 26, 2010 at 12:27 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 18 quoted lines
> On Sat, Sep 25, 2010 at 13:33, Jon Seymour <jon.seymour@gmail.com> wrote:
>
>> +       : >expected &&
>
> We've been dropping the ":>foo" style in favor of ">foo" in other
> tests. There's no need for the ":".
>
>> +       echo -X > expected &&
>> +       echo -q > expected &&
>> +       echo -X > expected &&
>> +       echo --no-flags > expected &&
>
> Maybe some echo implementations don't like flag-like params, and we need:
>
>    printf "%s\n" "-X"
>
> here. I don't know whether that's the case.
>
Thanks for the review.

My latest revision incorporates this feedback, although I didn't use extra quotes around -X. (e.g. I wrote printf "%s\n" -X)

jon.
Previous: Ævar Arnfjörð BjarmasonNext: Jon Seymour
Message 5 of 8 in “rev-parse: allow --flags to output rev-parse-like flags”
  1. 0/4 rev-parse: allow --flags to output rev-parse-like flagsJon Seymour, Sep 25, 2010
  2. 1/4 rev-parse: stop interpreting flags as options to rev-parse once --flags is specifiedJon Seymour, Sep 25, 2010
  3. 2/4 rev-parse: add tests for git rev-parse --flags.Jon Seymour, Sep 25, 2010
  4. Ævar Arnfjörð BjarmasonSep 25, 2010
  5. Jon SeymourSep 25, 2010
  6. 3/4 rev-parse: update documentation of --flags and --no-flags optionsJon Seymour, Sep 25, 2010
  7. 4/4 rev-parse: make --flags imply --no-revs for remaining arguments.Jon Seymour, Sep 25, 2010
  8. Jon SeymourSep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.